Refactor to use source & headers structure #2302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Haven't reviewed in depth, but I think this is roughly in the same direction I'd start. Obviously still needs a lot of work to get the subprojects building and all tests passing again, after that I can give it a closer look. |
jakubberkop force-pushed the source_and_headers branch 4 times, most recently from 2e74d6c to 63dfd6b Compare Author
| Ready for a review. @robbederks
|
jakubberkop force-pushed the source_and_headers branch from 63dfd6b to 45ff79f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Work in progress for #2171.
Is this the refactor you have in mind? @robbederks
Building of jungle and body binaries are commented out of now, just to get a poc of the refactor.