Skip to content

Conversation

@gregjkal
Copy link

@gregjkal gregjkal commented Oct 28, 2021

As of Django 3.2, explicitly setting default_app_config is deprecated. This check allows django-select2 to continue supporting earlier versions of Django while silencing this deprecation warning. Fixes #97.

As of Django 3.2, explicitly setting `default_app_config` [is deprecated](https://docs.djangoproject.com/en/3.2/releases/3.2/#features-deprecated-in-3-2). This check allows django-select2 to continue supporting earlier versions of Django while silencing this deprecation warning.
@gregjkal gregjkal marked this pull request as ready for review October 29, 2021 15:56
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, like the if approach, it allows me to search for the version, when I want to remove support and drop the workaround. I only had one some comment for you to consider.

@codingjoe codingjoe merged commit 5f0d76d into codingjoe:master Nov 3, 2021
@gregjkal gregjkal deleted the patch-2 branch November 3, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants