-
- Notifications
You must be signed in to change notification settings - Fork 57
Clarify that cache is not strictly necessary #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| I think the assertion that a cache isn't required is false. You can verify this by running with the cache entirely disabled (i.e., use the Django The code is not only assuming the presence of a cache, but of a persistent cache that never culls anything. This was alluded to in this issue, where the conversation didn't go so well, but I think the original point is valid: it's very easy to break a widget just because it's cache entry was removed for any reason. This is easy to demonstrate with the |
Well, I'm using it at the moment with the default django cache and I facing no issues so far... |
| Im using the default cache (which from the django docs I gather is the LocMemCache), which is also not persistent, with no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me thanks @abeforgit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, actually it doesn't work for me. The cache needs to be persistent, not matter the setup. If you use a single app node setup, of course you don't need a cache that is persistent across mutliple nodes, thus LocMemCache would do.
The paragraph was introduced because I got many people reporting problems because they forgot to set up a persistent cache. I know it makes initial set up a little harder, but I don't see a way around it.
| That being said, I welcome changes on the docs and this paragraph too. Maybe you can rewrite it a little be more comprehensive. |
| Ah I think that is indeed the source of most of the confusion. Ill rewrite it sometime this week, hopefully tomorrow |
Codecov Report
@@ Coverage Diff @@ ## master #16 +/- ## ========================================= Coverage ? 99.58% ========================================= Files ? 7 Lines ? 240 Branches ? 0 ========================================= Hits ? 239 Misses ? 1 Partials ? 0 Continue to review full report at Codecov.
|
| "Tomorrow" turned out to be about 4 months later... funny how that goes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abeforgit,
Excellent addition to the docs! Good documentation is key. Great contribution.
Best,
Joe
While it is definitely a good idea to stress the importance of a good cache setup, the current docs make it sound like it won't work at all without, which doesn't seem to be the case. For quick tests and small-scale projects it is good to know that it will run fine without.
Closes #11