Skip to content

Added SELECT2_THEME settings #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Added SELECT2_THEME settings #103

merged 1 commit into from
Nov 5, 2021

Conversation

@CleitonDeLima
Copy link

Resolve: #101
@codecov
Copy link

codecov bot commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #103 (1f042f4) into master (5a835f3) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #103 +/- ## ========================================== - Coverage 99.58% 99.18% -0.40%  ========================================== Files 7 7 Lines 241 246 +5 ========================================== + Hits 240 244 +4  - Misses 1 2 +1
Impacted Files Coverage Δ
django_select2/conf.py 100.00% <100.00%> (ø)
django_select2/forms.py 99.44% <100.00%> (-0.56%) ⬇️
django_select2/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a835f3...1f042f4. Read the comment docs.
codingjoe
codingjoe reviewed Nov 5, 2021
View reviewed changes
@codingjoe
Copy link
Owner

Pretty much perfect, thanks @CleitonDeLima, very impressive.
codingjoe
codingjoe approved these changes Nov 5, 2021
View reviewed changes
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX 👍
@codingjoe codingjoe merged commit 3ef5fd1 into codingjoe:master Nov 5, 2021
@CleitonDeLima CleitonDeLima deleted the issue/101 branch November 5, 2021 14:39
@felixrindt felixrindt mentioned this pull request Nov 8, 2021
Merged
@GorlikItsMe
Copy link

Hi. Can someone make an example of how to change the theme in documentation?
@codingjoe
Copy link
Owner

Excellent idea. @CleitonDeLima would you do the honors?
@CleitonDeLima
Copy link
Author

Hi @GorlikItsMe

@codingjoe , documentation is not generated through docstrings?
I remember adding some comments about it.
@GorlikItsMe
Copy link

https://django-select2.readthedocs.io/en/latest/django_select2.html#django_select2.conf.Select2Conf.CSS

SELECT2_CSS AND SELECT2_JS are
But not SELECT2_THEME
@CleitonDeLima
Copy link
Author

SELECT2_CSS AND SELECT2_JS are But not SELECT2_THEME

see here
I don't think the documentation has been updated yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@CleitonDeLima @codingjoe @GorlikItsMe