Fix session key security issues #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1 +/- ## ===================================== Coverage 100% 100% ===================================== Files 11 12 +1 Lines 188 201 +13 ===================================== + Hits 188 201 +13
Continue to review full report at Codecov.
|
Since the password was set to None, the session hash was always identical and predictable for an attacker. A new random salt is added to replace the password which served this funciton before. Should the new session salt is set be default to a rendom value. Should the salt be set to None for some reason, the `get_session_auth_hash` method will raise a `ValueError`. The password field is now removed from the user model. It will raise a `FieldDoesNotExist` error, should the attribute be access further preventing similar security issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the password was set to None, the session hash was always
identical and predictable for an attacker. A new random salt is
added to replace the password which served this funciton before.
Should the new session salt is set be default to a rendom value.
Should the salt be set to None for some reason, the
get_session_auth_hashmethod will raise aValueError.The password field is now removed from the user model. It will
raise a
FieldDoesNotExisterror, should the attribute beaccess further preventing similar security issues.