Skip to content

Modified Login UI #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2019
Merged

Modified Login UI #26

merged 1 commit into from
Dec 13, 2019

Conversation

txrp0x9
Copy link
Contributor

@txrp0x9 txrp0x9 commented Dec 10, 2019 •
edited
Loading

About

This PR modifies the default authorization login user-interface. It also adds the ability to logout once logged in by deleting the saved access token.

Changes

  • Extracted the toolbar to a new component
  • Changed the whole look of the authorization page
  • Added a logout feature to the toolbar which deletes the stored access token and allows you to login again.

Expected Results

The authorization page should look like this:
expected

The Navigation Bar should look like this after logging in:
expected2

Testing

  • Launch your application locally by follow the steps in the readme
  • Make sure the page looks similar to the one as described above.
  • Click on the Login button.
  • After logging in make sure the Logout button appears on the navigation bar.
@shivamluthra
Copy link
Collaborator

Hi! @TORPEDO99 , Please prefer posting screenshots for UI based issues' review. You can follow this template.
@txrp0x9
Copy link
Contributor Author

txrp0x9 commented Dec 13, 2019

Restyled the AuthView component and extracted toolbar and the login button components. Read PR details for the new look.
@txrp0x9
Copy link
Contributor Author

txrp0x9 commented Dec 13, 2019 •
edited
Loading

Changed the fonts to Playfair Display, Roboto and Roboto Condensed.
@txrp0x9
Added a Logout mechanism and add some login ui
7f146e0 
Changed auth page and added logout button Changed some fonts
@ayushnagar123 ayushnagar123 self-requested a review December 13, 2019 17:41
@jaskiratsingh2000
Copy link
Member

Looks good ✌😉
shivamluthra
shivamluthra approved these changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@shivamluthra shivamluthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciable! 🎉
@shivamluthra shivamluthra merged commit ba5e8a4 into codeuino:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@txrp0x9 @shivamluthra @jaskiratsingh2000 @ayushnagar123