Update hacktoberfest logic #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I prefer to stick to only the default resources inside of controller actions when possible. A pattern I use in other places is to use show coupled with params[:id] to represent differentiated resources. In this process I removed the API handler (as I don't think it's needed here). I also took out the logic for showing repo subscriptions. I wanted to get a barebones but solid page up first and make sure the performance is okay before adding in extra functionality. I also moved from the `includes(:repo_labels)` to a `joins(:repo_labels)` as the first will force all repo labels into memory and it can have massive memory side effects.
schneems force-pushed the avcwisesa-topics_view branch from c68d30c to 7c551ef Compare schneems force-pushed the avcwisesa-topics_view branch from 691b101 to cc84a7e Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Building on #1795