Start Preview's history at index of 0 #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| This is great! Thanks a lot for fixing this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The browser preview starts with an empty
historyarray in state and ahistoryPositionof-1. After initializing, the URL listener dispatches aREPLACE, which adds an entry to the preview'shistoryarray, but thehistoryPositionis still-1. This causes two incorrect behaviors: 1) the preview thinks that it can go forward immediately and 2) the preview can never return to the initial location.(I made the
REPLACEchange in #1158, so I suppose that this bug is my fault. I'm not sure how I didn't notice the issue until now, but I didn't spot any other changes, so it must have existed since that PR.)What is the new behavior?
By starting with the
historyPositionof0, the preview 1) cannot go forward immediately and 2) can return to the initial location.Checklist: