Skip to content

Conversation

@ShreyPurohit
Copy link
Contributor

Issue Link: Improvement: Make the CLI work on windows

Key changes:

  • Added _normalize_path function to handle platform-specific path normalization
  • Added _normalize_path_str function to ensure consistent forward slash separators in output
  • Added _get_encoding_list function for cross-platform file encoding detection
  • Enhanced Windows symlink handling in _is_safe_symlink
  • Updated file content string generation to use normalized paths
  • Improved file reading with multiple encoding attempts for better cross-platform compatibility
  • Fixed path separator inconsistencies in test outputs

** Additionally, this project would not run on Windows Systems due to setup.py handling Readme File.
Fixed the above as well

@cyclotruc cyclotruc merged commit a2d9dfa into coderamp-labs:main Feb 4, 2025
12 checks passed
@cyclotruc
Copy link
Member

@ShreyPurohit Thanks a lot for your work on this! very happy that we're now officially supporting Windows thanks to you

FOLKS-Tech pushed a commit to FOLKS-Tech/gitingest that referenced this pull request Sep 5, 2025
* Improvement: Make the CLI work on windows * Fix tmp file creation and add test * add error message when git missing * update CI to test windows and Macos --------- Co-authored-by: Romain Courtois <romain@coderamp.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants