Skip to content

Conversation

@schmidtw
Copy link

This is a simple approach to providing users with a relatively easy and safe way to be notified of when a ping comes from the server to the client. It doesn't allow for any action to be take aside from letting 3rd party code know something happened.

This should address #246.

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @schmidtw but there's already #307 and I believe it has a better API with the context and payload in the callback. It also implements a callback for pongs.

@nhooyr nhooyr closed this Dec 19, 2023
@schmidtw
Copy link
Author

I didn't see that PR before. Can #307 be merged?

@nhooyr
Copy link
Contributor

nhooyr commented Dec 19, 2023

Not at the moment. I'm busy the next few weeks but I'll be working on this library again in January/February full time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants