Skip to content

Migrate from deprecated io/ioutil #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

Migrate from deprecated io/ioutil #371

merged 1 commit into from
Oct 10, 2023

Conversation

@keystroke3
Copy link
Contributor

@keystroke3 keystroke3 commented Feb 25, 2023

This addresses #370 by switched out ioutil methods with their io and os equivalents.
@keystroke3 keystroke3 requested a review from nhooyr as a code owner February 25, 2023 21:30
nhooyr
nhooyr approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me but will have to wait for #256
@nhooyr nhooyr changed the base branch from master to dev October 10, 2023 15:31
@nhooyr
Copy link
Contributor

nhooyr commented Oct 10, 2023

Sorry for the delay, thanks @keystroke3
@nhooyr nhooyr merged commit 91423a9 into coder:dev Oct 10, 2023
@keystroke3
Copy link
Contributor Author

keystroke3 commented Oct 12, 2023

No problem. I am happy to see it merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@keystroke3 @nhooyr