fix: validate resources against available features before creating #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 task
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from aad8947 to a5e6e53 Compare ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from ef38461 to b02f6a8 Compare ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from a5e6e53 to db62dcc Compare ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from b02f6a8 to eaab432 Compare ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from db62dcc to 04f9b53 Compare ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from eaab432 to cd6a681 Compare ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 04f9b53 to 41956b0 Compare ethanndickson changed the base branch from 08-01-fix_template_version_replacement_metadata_updates to graphite-base/62 ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 41956b0 to 19a4577 Compare ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 19a4577 to 31a1a2b Compare 
deansheather approved these changes Aug 9, 2024
ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 31a1a2b to d5b4ace Compare ethanndickson deleted the 08-06-fix_validate_resources_against_available_features_before_creating branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #61
We can't actually validate the fields during the plan, as we don't have access to the provider data store (with the
*codersdk.Client) during plan modification, or validation.Instead we do it during
Createfor enterprise-only resources, andCreateandUpdatefor templates.