Skip to content

feat: surface errors to users #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 31, 2025
Merged

feat: surface errors to users #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e994d06
wip: generate types with guts
brettkolodny May 31, 2025
46d8762
wip: still trying to generate types with guts
brettkolodny May 31, 2025
8a41403
feat: generate types for dynamic paramaters
brettkolodny May 31, 2025
e28d874
fix: generate wasm that won't fail
brettkolodny May 31, 2025
2059bcf
chore: clean up type gen script
brettkolodny May 31, 2025
e20e26a
feat: render top level and parameter errors
brettkolodny May 31, 2025
4bd8d7e
fix: improve accesibility while error pane is open
brettkolodny May 31, 2025
c513f59
fix: make error popup more accesible
brettkolodny May 31, 2025
a3407b6
fix: more accessibility improvements
brettkolodny May 31, 2025
4c748e2
chore: remove unused import
brettkolodny May 31, 2025
46df927
fix: restore code overflow behavior
brettkolodny May 31, 2025
708b985
feat: surface logs as errors
brettkolodny May 31, 2025
0356bfb
fix: styling
brettkolodny May 31, 2025
73b04d8
fix: handle overflowing amount of errors
brettkolodny May 31, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: generate wasm that won't fail
  • Loading branch information
@brettkolodny
brettkolodny committed May 31, 2025
commit e28d874b49a2fa3eaf99bab58ae030b9efe6db6f
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@
build-wasm: build/preview.wasm
mkdir -p public/build

# TODO: remove vendoring workaround
build/preview.wasm: $(GO_SRC_FILES)
GOOS=js GOARCH=wasm go build -C ./preview -o ../public/build/preview.wasm o
cd preview && go mod vendor
(find preview/vendor -name "*.go" -type f -exec sed -i 's/os\.Getwd()/"", nil/g' {} +)
GOOS=js GOARCH=wasm go build -C ./preview -o ../public/build/preview.wasm
rm -rf preview/vendor

.PHONY: gen-types
gen-types: src/gen/types.ts
Expand Down
Binary file modified public/build/preview.wasm
View file
Open in desktop
Binary file not shown.