feat: support gemini cli #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tting in msgfmt.go
Collaborator Author
Collaborator Author
| fixing tests in a while |
Collaborator Author
|
|
hugodutka requested changes Jul 21, 2025
Collaborator
hugodutka left a comment
hugodutka left a comment There was a problem hiding this comment.
Thank you for contributing @35C4n0r! The PR looks good - it's only missing tests. Could you add a couple of test cases for gemini to https://github.com/coder/agentapi/tree/main/lib/msgfmt/testdata/format? They will be run by TestFormatAgentMessage after you add AgentTypeGemini to this array.
Collaborator Author
| @hugodutka thanks for the review, will add the tests :) https://discord.com/channels/747933592273027093/1143265221545316445/1396545560768417792 |
Collaborator Author
| @hugodutka added the tests |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/0c2f8418ee774f5dafcbd16da6a21f35?sid=da185296-e99c-4201-8614-52015898a090