Add CNAME #113
Merged
Add CNAME #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
paulbalandan approved these changes Dec 19, 2023
lonnieezell approved these changes Dec 19, 2023
datamweb reviewed Dec 19, 2023
| ## Docs | ||
| | ||
| Read the full documentation: https://codeigniter4.github.io/settings/ | ||
| Read the full documentation: https://settings.codeigniter.com |
Contributor
There was a problem hiding this comment.
If you are going to use https://settings.codeigniter.com, it is better to use it in all cases. including file composer.js & mkdocs.yml and...
Member Author
There was a problem hiding this comment.
IMO composer.json should link to the source code only.
As for MkDocs... do you mean instead of linking to codeigniter.com in extra.homepage?
Contributor
There was a problem hiding this comment.
IMO composer.json should link to the source code only.
Thanks, I didn't know that.
As for MkDocs... do you mean instead of linking to codeigniter.com in
extra.homepage?
Sorry. No, it's fine now, I thought there was a link to the docs defined in MkDocs.
datamweb approved these changes Dec 19, 2023
Member Author
| Thanks all. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR adds CNAME and updates the docs URL in readme.
Checklist: