Skip to content

Conversation

@samsonasik
Copy link
Member

For example, in appstarter, it will be in vendor directory, so the following directories and files need to be ignored from download:

/application/ /public/ /writable/ /.gitignore /.travis.yml /env /phpunit.xml.dist /spark 
@jim-parry
Copy link
Contributor

Actually, my plan was to keep those folders, specifically application & public.
I would like to add a post update composer script to point out what's different between them & the tailored ones, eg. app vs vendor/codeigniter4/framework/app.

I don't know that absolutely everything has to be there, but they were chosen to be there as examples or which might change over time.

Just adding something to .gitattributes might not be the best/only way of dealing with this ... the admin release script should probably be adjusted too. I am not too worried about that - I have some tweaking to do to it for alpha.4 this coming weekend.

@jim-parry
Copy link
Contributor

By the way, no PRs accepted for this repo ... they all go to the main development one (codeigniter4).
The equivalent would be a PR modifying admin/framework/.gitattributes (or whichever is appropriate) there.

@jim-parry jim-parry closed this Dec 10, 2018
karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
i have an error like this CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found #0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once() codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint() codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize() codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...') codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...') codeigniter4#5 {main}
karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
fix this error CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found #0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once() codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint() codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize() codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...') codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...') codeigniter4#5 {main}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants