Skip to content

fix: Skip hostname checks if CURLRequest options 'verify' is set to false. #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix: Skip hostname checks if CURLRequest options 'verify' is set to false. #8257

wants to merge 4 commits into from

Conversation

@NicolaeIotu
Copy link
Contributor

@NicolaeIotu NicolaeIotu commented Nov 26, 2023 •
edited by kenjis
Loading

When CURLRequest options 'verify' is set to false, some CURLOPT_SSL_... options should be disabled in such a way as to allow requests to pass through in case the destination is for example on private networks.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide
@NicolaeIotu
Skip hostname checks if CURLRequest options 'verify' is set to false.
5c4a23b 
When CURLRequest options 'verify' is set to false, some CURLOPT_SSL_... options should be disabled in such a way as to allow requests to pass through in case the destination is for example on private networks.
@kenjis
Copy link
Member

kenjis commented Nov 26, 2023

Thank you for sending a PR.
But some checks were not successful.
Please fix the code to pass all checks.

First of all, you need to sign your git commits.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
@kenjis kenjis changed the title Skip hostname checks if CURLRequest options 'verify' is set to false. fix: Skip hostname checks if CURLRequest options 'verify' is set to false. Nov 26, 2023
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 26, 2023
@NicolaeIotu
Skip hostname checks if CURLRequest options 'verify' is set to false.
d70b40a 
When CURLRequest options 'verify' is set to false, some CURLOPT_SSL_... options should be disabled in such a way as to allow requests to pass through in case the destination is for example on private networks.
@NicolaeIotu
Merge remote-tracking branch 'refs/remotes/origin/CURLOPT_SSL_VERIFYH…
ac21f95 
…OST' into CURLOPT_SSL_VERIFYHOST
@NicolaeIotu
Merge branch 'codeigniter4:develop' into CURLOPT_SSL_VERIFYHOST
56c890f
@NicolaeIotu
Copy link
Contributor Author

I will redo this PR.
@NicolaeIotu NicolaeIotu deleted the CURLOPT_SSL_VERIFYHOST branch November 26, 2023 11:24
@kenjis kenjis mentioned this pull request Nov 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

2 participants

@NicolaeIotu @kenjis