Issue #73: Use configured file encoding for JSR-199 Eclipse compiler #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The JSR-199 Eclipse compiler needs to have the encoding set explicitly for its javax.tools.StandardJavaFileManager. Use the encoding configured in the CompilerConfiguration or in the compiler arguments, and fall back to the platform default only if none is given explicitly.
| Anyone interested in reviewing or even merging this fix for #73? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The JSR-199 Eclipse compiler needs to have the encoding set explicitly
for its javax.tools.StandardJavaFileManager. Use the encoding configured
in the CompilerConfiguration or in the compiler arguments, and fall back
to the platform default only if none is given explicitly.