Skip to content

Conversation

jwgmeligmeyling
Copy link
Contributor

getLogger() may return null, this is problematic for occasions where logging is used without a null check. This PR adds the required null check for two cases in the JavacCompiler.

@olamy
Copy link
Member

olamy commented May 17, 2018

I wonder how getLogger() can return null?
what is your use case? does it happen within a maven plugin?

@jwgmeligmeyling
Copy link
Contributor Author

jwgmeligmeyling commented May 17, 2018

My use case is Arquillian Shrinkwrap! Unfortunately they do not attach a logger (I am creating a PR for that too, but mean while I think it would be wise you consistently use logging, either a null return of getLogger() should be treated everywhere, or the null should not be accepted in the first place.

@olamy olamy merged commit e355785 into codehaus-plexus:master Jul 15, 2018
@jwgmeligmeyling jwgmeligmeyling deleted the fix/logging-disabled-compilation branch September 13, 2018 10:31
@jwgmeligmeyling
Copy link
Contributor Author

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants