Require JDK 17 for build #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
slawekjaranowski commented Dec 9, 2023
slawekjaranowski commented - reuse javaVersion property from parent
- property maven.compiler.release is set by parent for JDK 11+
- reuse checking of bytecode version from parent
| Required for #326 - newer version of eclipse compiler |
slachiewicz approved these changes Dec 9, 2023
| We need a newer Maven 3.9.6+ due to old sisu without support for JDK 11+ |
| To build, test the eclipse compiler component. But later all other compilers can be used normally. |
- reuse javaVersion property from parent - property maven.compiler.release is set by parent for JDK 11+ - reuse checking of bytecode version from parent
slawekjaranowski force-pushed the jdk-17 branch from c1ab31b to 45ea5bc Compare
Good idea 👍 |
slachiewicz approved these changes Dec 10, 2023
pzygielo reviewed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.