Improve locking on JavacCompiler #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
gnodet commented Oct 28, 2023
gnodet commented - the code synchonizes on the CopyOnWriteArrayList which is a concurrent collection
- the double check locking pattern is badly written and does not actually double checks
- the code synchonizes on the CopyOnWriteArrayList which is a concurrent collection - the double check locking pattern is badly written and does not actually double checks
gnodet force-pushed the improve-locking-javac branch from 5204b48 to 3dc1ca7 Compare 
rmannibucau approved these changes Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.