Initial support for referencing dll libraries packaged within artifacts. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Oops.
We will verify. I have 1.7 and 1.8 installed.
Thanks.
There was a problem hiding this comment.
In fact I think it's ok to use 1.7 for compilers other than javac.
olamy added a commit that referenced this pull request May 25, 2015
Initial support for referencing dll libraries packaged within artifacts.
ethiclab referenced this pull request May 26, 2015
This updates the error-prone version to 2.0, which includes full Java 8 support. Error-prone now repackages a copy of javac8, which requires some classloading changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
We added the following feature that allows us to unpack .net libraries contained within jars found at class path entries.
Please let us know if you consider it can be merged.
Thanks,
EthicLab.