Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Aug 15, 2025

Also, lessen the pressure (creating eagerly as many threads as many CPU cores per archive is a huge pressure), as many times they are simply unused.

Also, do not pre-create as many threads as many cores reported by Java as many times they are simply unused.
@cstamas
Copy link
Member Author

cstamas commented Aug 15, 2025

Proof why "rebuild on each Java version" pattern is totally wrong: The CI. The JARs should be built on controlled Java + Maven version and then test performed on matrix, as right now, what you can use is really matrix minimum and that is outright silly.

@slawekjaranowski
Copy link
Member

Proof why "rebuild on each Java version" pattern is totally wrong: The CI. The JARs should be built on controlled Java + Maven version and then test performed on matrix, as right now, what you can use is really matrix minimum and that is outright silly.

It is easier configuration ...

@cstamas cstamas marked this pull request as ready for review August 19, 2025 16:26
@cstamas
Copy link
Member Author

cstamas commented Aug 19, 2025

Thanks!

Still, the reason I dislike this is that consumer may rightfully ask "and what Java was used to release this?" -- as we basically make a feature depend on Java version we use to release. The proposed solution (use one version to build and enforce it) makes the presence of feature clear, and not kinda optional-ish.

Also, if someone releases this library and by mistake use Java 17 or 11 (as library is Java 8+), nothing will happen: no big red alarm will ring, and the only way to figure out what happened is to inspect the release output Java...

@slachiewicz
Copy link
Member

Or simply, faster switch to Java 21

@slawekjaranowski
Copy link
Member

I added check in release profile to use 21+, so we will not have a mistake

@slawekjaranowski
Copy link
Member

We can merge it ...
I will look at using many deprecated methods from commons-io .... and next release it

@slawekjaranowski slawekjaranowski merged commit 6f0ad55 into master Aug 19, 2025
15 checks passed
@slawekjaranowski slawekjaranowski deleted the vt branch August 19, 2025 20:04
slawekjaranowski referenced this pull request in support-and-care/exec-maven-plugin Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants