detect permissions for addFile #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can we add a test for it? |
| yes, that would be better than my manual tests inside maven-source-plugin: I have no idea, need to check how I can create such test, yes |
| @slawekjaranowski done |
slawekjaranowski approved these changes Jul 15, 2023
| @hboutemy what label should we add for this? enhancement or bug? |
| I'd say bug, as this API behaviour was not consistent with others |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
found while working on
maven-source-pluginissue onpom.propertiesandpom.xml: https://issues.apache.org/jira/browse/MSOURCES-137need to detect permission from file instead of blindly applying (unset) default file mode