Skip to content

[feat] improve inst combine pass, optimize generated soufflé code #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiexie merged 7 commits into from
Feb 11, 2025
Merged

[feat] improve inst combine pass, optimize generated soufflé code #94

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cad9242
update documents
ValKmjolnir Feb 8, 2025
1fb607b
some binary operators do not do binding
ValKmjolnir Feb 10, 2025
8466767
add comments
ValKmjolnir Feb 10, 2025
ffd7830
improve warning of unused schema parameters
ValKmjolnir Feb 10, 2025
e40d630
inst combine will run multiple times
ValKmjolnir Feb 10, 2025
1a5c931
replace lir find call with 2 lir::store
ValKmjolnir Feb 10, 2025
127ea85
optimize key_eq generated temp variable
ValKmjolnir Feb 11, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
some binary operators do not do binding
  • Loading branch information
@ValKmjolnir
ValKmjolnir committed Feb 10, 2025
commit 1fb607b15a8ecc2864259f69a4d1d7f07068688d
7 changes: 6 additions & 1 deletion godel-script/godel-frontend/src/sema/ungrounded_checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,12 @@ bool ungrounded_parameter_checker::check_non_binding_binary_operator(binary_oper
return node->get_operator_type() == binary_operator::type::add ||
node->get_operator_type() == binary_operator::type::sub ||
node->get_operator_type() == binary_operator::type::mult ||
node->get_operator_type() == binary_operator::type::div;
node->get_operator_type() == binary_operator::type::div ||
node->get_operator_type() == binary_operator::type::compare_not_equal ||
node->get_operator_type() == binary_operator::type::compare_less ||
node->get_operator_type() == binary_operator::type::compare_less_equal ||
node->get_operator_type() == binary_operator::type::compare_great ||
node->get_operator_type() == binary_operator::type::compare_great_equal;
}

bool ungrounded_parameter_checker::visit_call_expr(call_expr* node) {
Expand Down