⚡️ Speed up function encode_query by 24% #5
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📄 24% (0.24x) speedup for
encode_queryinsrc/deepgram/core/query_encoder.py⏱️ Runtime :
9.09 milliseconds→7.31 milliseconds(best of149runs)📝 Explanation and details
The optimization achieves a 24% speedup through three key performance improvements:
1. Function Call Caching: The optimized code caches
isinstanceas_is_pydanticandpydantic.BaseModelasBaseModelwithinsingle_query_encoder. This eliminates repeated attribute lookups, particularly beneficial in tight loops where these functions are called frequently.2. Structural Logic Simplification: The original code used redundant
isinstancechecks with complex conditional logic (isinstance(query_value, pydantic.BaseModel) or isinstance(query_value, dict)). The optimized version separates these checks into distinct branches and directly callstraverse_query_dictfor dict values instead of going through the recursivesingle_query_encodercall, reducing function call overhead.3. Method Reference Caching: In
encode_query, the optimization cachesencoded_query.extendas a local variableextend, avoiding repeated attribute lookups during the loop iteration.The performance gains are most significant for test cases involving lists of dictionaries and Pydantic models, where the optimizations show 31-103% improvements (e.g.,
test_encode_query_large_list_of_dictsshows 101% speedup). This is because these scenarios trigger the tight loops where function call overhead is most impactful. Basic operations with simple data types show minimal improvements (0-8%), while complex nested structures benefit moderately (8-20%).The optimizations are particularly effective for workloads with repetitive dictionary/model processing, making it ideal for API query parameter encoding scenarios where large collections of structured data need to be flattened.
✅ Correctness verification report:
⚙️ Existing Unit Tests and Runtime
unit/test_core_query_encoder.py::TestEncodeQuery.test_complex_queryunit/test_core_query_encoder.py::TestEncodeQuery.test_empty_queryunit/test_core_query_encoder.py::TestEncodeQuery.test_none_queryunit/test_core_query_encoder.py::TestEncodeQuery.test_query_with_pydantic_modelsunit/test_core_query_encoder.py::TestEncodeQuery.test_query_with_special_valuesunit/test_core_query_encoder.py::TestEncodeQuery.test_simple_queryunit/test_core_query_encoder.py::TestQueryEncoderEdgeCases.test_circular_reference_protectionunit/test_core_query_encoder.py::TestQueryEncoderEdgeCases.test_unicode_and_special_charactersutils/test_query_encoding.py::test_encode_query_with_noneutils/test_query_encoding.py::test_query_encoding_deep_object_arraysutils/test_query_encoding.py::test_query_encoding_deep_objects🌀 Generated Regression Tests and Runtime
⏪ Replay Tests and Runtime
test_pytest_testsintegrationstest_integration_scenarios_py_testsunittest_core_utils_py_testsutilstest_htt__replay_test_0.py::test_deepgram_core_query_encoder_encode_querytest_pytest_testsintegrationstest_manage_client_py_testsunittest_core_query_encoder_py_testsunittest_type__replay_test_0.py::test_deepgram_core_query_encoder_encode_query🔎 Concolic Coverage Tests and Runtime
codeflash_concolic_d0k9fm5y/tmpa0ids3s_/test_concolic_coverage.py::test_encode_querycodeflash_concolic_d0k9fm5y/tmpa0ids3s_/test_concolic_coverage.py::test_encode_query_2To edit these changes
git checkout codeflash/optimize-encode_query-mh2rdmp9and push.