Skip to content

Conversation

@misrasaurabh1
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 commented Nov 8, 2025

PR Type

Enhancement


Description

  • Remove smoke tests from publish workflow

  • Simplify CI release pipeline steps


Diagram Walkthrough

flowchart LR Build["Build package"] -- previously followed by --> SmokeWheel["Smoke test (wheel)"] Build -- previously followed by --> SmokeSdist["Smoke test (sdist)"] Build -- now directly --> Publish["Publish to PyPI"] 
Loading

File Walkthrough

Relevant files
Enhancement
publish.yml
Drop smoke tests from publish workflow                                     

.github/workflows/publish.yml

  • Remove wheel smoke test step
  • Remove sdist smoke test step
  • Keep build and publish steps unchanged
  • Conditionals for tag check remain intact
+0/-9     

Signed-off-by: Saurabh Misra <misra.saurabh1@gmail.com>
@github-actions github-actions bot added the workflow-modified This PR modifies GitHub Actions workflows label Nov 8, 2025
@misrasaurabh1 misrasaurabh1 merged commit 349a40f into main Nov 8, 2025
20 of 22 checks passed
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Process Risk

Removing smoke tests eliminates a safeguard that validated built artifacts before publishing. Consider keeping a minimal verification step (e.g., import/package metadata check) to avoid publishing broken wheels/sdists.

- name: Build if: steps.check_tag.outputs.exists == 'false' run: uv build - name: Publish to PyPI if: steps.check_tag.outputs.exists == 'false' run: uv publish
Publishing Preconditions

Ensure uv publish uses correct auth/token and repository settings for PyPI vs TestPyPI; without a pre-publish gate, a misconfiguration could push unintended releases.

- name: Publish to PyPI if: steps.check_tag.outputs.exists == 'false' run: uv publish
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Ensure authenticated publishing

Add explicit authentication to ensure publishing works in CI. Without passing
credentials, uv publish may fail or inadvertently pick up local config; use the
standard PyPI token secret and set the repository URL explicitly if needed.

.github/workflows/publish.yml [59-61]

 - name: Publish to PyPI if: steps.check_tag.outputs.exists == 'false' - run: uv publish + env: + UV_PUBLISH_TOKEN: ${{ secrets.PYPI_API_TOKEN }} + run: uv publish --token "$UV_PUBLISH_TOKEN"
Suggestion importance[1-10]: 6

__

Why: Adding explicit authentication via a PyPI token can prevent CI publish failures, but the PR context doesn't show whether credentials are already provided implicitly, so impact is moderate and somewhat assumptive.

Low
General
Build in isolated environment

Ensure the build uses a clean Python environment to avoid implicit dependencies
affecting artifacts. Use setup action or uv to create an isolated environment before
building.

.github/workflows/publish.yml [55-57]

 - name: Build if: steps.check_tag.outputs.exists == 'false' - run: uv build + run: | + uv venv --python 3.11 + . .venv/bin/activate + uv build
Suggestion importance[1-10]: 5

__

Why: Building in an isolated venv can improve reproducibility; however, uv build is typically already reproducible and the change adds complexity and assumes shell/venv specifics, yielding a modest benefit.

Low
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review effort 1/5 workflow-modified This PR modifies GitHub Actions workflows

2 participants