Skip to content

Undo Optimization Impact #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

Undo Optimization Impact #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions codeflash/optimization/function_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,14 +1461,14 @@ def process_review(

if raise_pr or staging_review:
data["root_dir"] = git_root_dir()
Copy link

@saga4893 saga4893 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this condition now required?
Copy link
Contributor Author

@aseembits93 aseembits93 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's from the original code, it's still required
try:
# modify argument of staging vs pr based on the impact
opt_impact_response = self.aiservice_client.get_optimization_impact(**data)
if opt_impact_response == "low":
raise_pr = False
staging_review = True
except Exception as e:
logger.debug(f"optimization impact response failed, investigate {e}")
# try:
# # modify argument of staging vs pr based on the impact
# opt_impact_response = self.aiservice_client.get_optimization_impact(**data)
# if opt_impact_response == "low":
# raise_pr = False
# staging_review = True
# except Exception as e:
# logger.debug(f"optimization impact response failed, investigate {e}")
if raise_pr and not staging_review:
data["git_remote"] = self.args.git_remote
check_create_pr(**data)
Expand Down
Loading