Added 13.Roman_to_Integer.cpp #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added c++ linked selution to Roman_to_Integer
| I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉 I'll take a look at it ASAP! |
| Wow !!! I can see that you have added 2 solutions but you have not updated both the problem links in README. After these changes we should be able to merge. |
from 20. Valid_Parentheses to Valid_Parentheses
README.md Outdated
| | # | Title | Solution | Time | Space | Difficulty | Tag | Note | | ||
| | ---- | ------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------- | ------ | ------ | ---------- | ---------------------- | ---- | | ||
| | 020 | [Valid Parentheses](https://leetcode.com/problems/valid-parentheses/) | [Python](./Python/20_ValidParentheses.py) | _O(n)_ | _O(n)_ | Easy | Stack | | | ||
| | 020 | [Valid Parentheses](https://leetcode.com/problems/valid-parentheses/) | [Python](./Python/20_ValidParentheses.py) [C++](./C++/20. Vlalid_Parentheses.cpp) | _O(n)_ | _O(n)_ | Easy | Stack | | |
There was a problem hiding this comment.
Path is wrong here
Makd it correct like below
C++
There was a problem hiding this comment.
Indeed I've forgotten to adjust the path as well.
Thanks for the patience.
Indeed I've forgotten to adjust the path as well. Thanks for the patience
GouravRusiya30 approved these changes Aug 6, 2021
| Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the problem and about the approach to solve the solution. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Put check marks:
Have you made changes in README file ?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
The code is relatively simple. The major catch to test has an example in the commenting parts of the code
Make sure all below guidelines are followed else PR will get Reject: