feat(autofix-container): add autofix request creation and error handling #3247
+41 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Implement a task to create autofix requests for submissions and handle errors when the creation fails. Introduce a button in the template to trigger this task with a loading state spinner and show a user-friendly error message if saving the request fails. This enables admins to initiate autofix requests directly from the submission details page.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| await autofixRequest.save(); | ||
| } catch { | ||
| this.autofixCreationError = 'Failed to create autofix request! Try again? Post on #engineering if this persists.'; | ||
| } |
There was a problem hiding this comment.
Bug: Ghost Record Corrupts UI State After Save
When autofixRequest.save() fails, the unsaved record remains in @submission.autofixRequests. This causes the template to switch from the error/retry UI to displaying the failed request, hiding the error message and create button. The record needs cleanup via rollbackAttributes() or unloadRecord(), or the error should be re-thrown to prevent the record from persisting in the relationship.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 1.58kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implement a task to create autofix requests for submissions and handle
errors when the creation fails. Introduce a button in the template to
trigger this task with a loading state spinner and show a user-friendly
error message if saving the request fails. This enables admins to
initiate autofix requests directly from the submission details page.
Note
Adds a button and task to create an
autofix-requestfor a submission with spinner feedback and error alert on failure.autofix-container.hbs):PrimaryButtonWithSpinnerto create an autofix request when none exist, bound tocreateAutofixRequestTaskandhandleCreateAutofixButtonClick.AlertWithIconwhenautofixCreationErroris set.autofix-container.ts):storeservice and tracksautofixCreationError.createAutofixRequestTask(drop policy) to create and save anautofix-requestlinked to@submission, setting an error message on failure.handleCreateAutofixButtonClickaction to trigger the task.Written by Cursor Bugbot for commit 1da7b88. This will update automatically on new commits. Configure here.