refactor: remove step switcher component and references #3231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Bundle ReportChanges will decrease total bundle size by 239.23kB (-0.61%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Test Results674 tests - 3 623 ✅ - 3 9m 5s ⏱️ -7s Results for commit e847fcf. ± Comparison against base commit 3d17865. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Remove the StepSwitcherContainer component and its logic from the codebase due to redesign or simplification of navigation controls. Also remove its use from the navigation controls template to clean up the UI and improve code maintainability.
Rename component NavigationControls to TopRightSection to better reflect its purpose within the course page header. Update all references, including template invocation, class name, test selectors, and type registrations to maintain consistency. This improves code clarity and aligns naming with component functionality.
Remove the StepProgressIndicator banner for steps that are neither complete nor in progress, as users should not focus on this area during such steps. This simplifies the UI and avoids unnecessary distraction.
Move the mobile sidebar toggle button to the main header section for better accessibility and visual hierarchy. Remove redundant mobile sidebar button from the top-right section and adjust flex layouts for cleaner alignment and spacing. Update padding in course template for consistent vertical spacing. Remove unused onMobileSidebarButtonClick arg from top-right section component. These changes enhance usability and streamline the header UI.
rohitpaulk force-pushed the remove-step-switcher-component branch from 813b835 to 79ef162 Compare This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Remove unused clickable and text selectors from course-page header component to simplify the test code. Delete deprecated acceptance tests covering beta and free course labels that are no longer relevant, reducing test maintenance overhead and improving suite focus.
Clean up the view-course-stages-test by removing the unused import of FakeDateService. This reduces clutter and improves code maintainability without affecting test functionality.
| <span class="font-mono text-base sm:text-lg xl:text-xl"> | ||
| <span class="text-gray-300 dark:text-gray-700">#</span><span | ||
| class="font-mono text-gray-400 dark:text-gray-600 uppercase" | ||
| >{{this.currentStepAsCourseStageStep.courseStage.slug}}</span> |
There was a problem hiding this comment.
Bug: Template Accesses Undefined Getter
The main-section.hbs template references this.currentStepAsCourseStageStep, but the main-section component doesn't have a backing TypeScript file defining this getter. This logic was moved to TopRightSection.ts during the refactor, which will cause runtime errors when the template tries to access its properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove the StepSwitcherContainer component and its logic from the codebase
due to redesign or simplification of navigation controls. Also remove its use
from the navigation controls template to clean up the UI and improve code maintainability.
Note
Replaces header navigation controls with a new TopRightSection, removes the step switcher component, updates header layout/spacings, and adjusts tests accordingly.
CoursePage::Header::TopRightSection(.hbs,.ts) with dark mode toggle, billing badge, and close button; updates registry to'CoursePage::Header::TopRightSection'.CoursePage::Header::NavigationControlsandCoursePage::StepSwitcherContainer(and related args likeonMobileSidebarButtonClickfrom the header controls component).CoursePage::Header::MainSection): restructures layout, adds mobile menu button, showsCoursePage::StepStatusPillon large screens only, and slots inTopRightSection(addsclass="flex-shrink-0").app/templates/course.hbs): adjusts header padding (pb-6→pb-2).tests/pages/components/course-page/header.jsto drop selectors for next/previous step and progress text; retains billing badges and close button.Written by Cursor Bugbot for commit e847fcf. This will update automatically on new commits. Configure here.