- Notifications
You must be signed in to change notification settings - Fork 23
Add sortable functionality to extensions in configure extensions modal. #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results675 tests +1 627 ✅ +1 9m 33s ⏱️ -6s Results for commit a44f312. ± Comparison against base commit 8b39b8d. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 2.47kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
Files in
|
a763828
to f554778
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added
@Arpan-206 what exactly was fixed here since the last review other than the first point (padding distance)? Disabling is still jarring - card stays for a while and then poof disappears: Screen.Recording.2025-10-19.at.15.38.38.movHandles are still not vertically aligned with text: ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added
Checklist:
[percy]
in the message to trigger)Note
Adds drag-and-drop reordering of enabled extensions, persists order via activation positions, and updates step list accordingly.
enabledExtensions
(sortable) anddisabledExtensions
with animated transitions inconfigure-extensions-modal/index.hbs
.extension-card.hbs
; card now accepts@onToggle
.extension-card.ts
to parentindex.ts
(handleExtensionToggle
), with optimistic state in card andonToggle
callback.handleSortableItemsReordered
to update activation positions and persist order.position
attr andreorder
collection action tocourse-extension-activation
model.StepListDefinition
now groups/sorts extension steps by activationposition
when astageList
exists.position
; addedPOST /course-extension-activations/reorder
to update positions and return sorted activations.position
.Written by Cursor Bugbot for commit a44f312. This will update automatically on new commits. Configure here.