Migrate team payment components to TypeScript #3123
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>
| Cursor Agent can help with this pull request. Just |
Test Results 1 files ±0 1 suites ±0 9m 46s ⏱️ - 4m 49s For more details on these errors, see this check. Results for commit f86626f. ± Comparison against base commit 4f65226. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 70 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
| @cursor fix lint errors |
| I refined the team payment details step by improving input handling for the number of seats and addressing Glint type errors, ensuring better data binding and developer experience.
Learn more about Cursor Agents |
Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist:
[percy]in the message to trigger)Migrate
app/components/team-payment-pagecomponents to TypeScriptThis PR migrates all components within
app/components/team-payment-pageand its subdirectories from JavaScript to TypeScript.The primary goal is to enhance type safety, improve maintainability, and enable better tooling support for these components.
Key changes include:
.jscomponent files to.ts.Signatureinterfaces for precise typing of component arguments, elements, and blocks.@service declare.{{! @glint-nocheck: not typesafe yet }}and{{! @glint-expect-error: not ts-ified yet }}comments from templates, leveraging Glint for template type checking.This migration ensures that the
team-payment-pagecomponents are fully type-safe and align with our TypeScript standards.Slack Thread