JS: explain camel case & ES6 rules #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wfleming force-pushed the will/js-es6-etc branch 2 times, most recently from 1726019 to 14b5009 Compare 
javascript/eslintrc-es6.js Outdated
| @@ -0,0 +1,10 @@ | |||
| module.exports = { | |||
| "rules": { | |||
| "consistent-this": [2, "prefer-fat-arrow-over-reassigning-thing"], | |||
Contributor
There was a problem hiding this comment.
Did you mean "...reassigning-thing", or "...reassigning-this"?
Contributor Author
There was a problem hiding this comment.
this. Already fixed.
Contributor Author
There was a problem hiding this comment.
I mean, you should't reassign thing either, probably.
wfleming force-pushed the will/js-es6-etc branch from 14b5009 to 456aa52 Compare 
Contributor
| This all LGTM. I think we have a loose requirement of a few LGTMs on styleguide stuff tough. |
wfleming force-pushed the will/js-es6-etc branch from 456aa52 to 48797ec Compare 
Contributor
| I'm +1 on all of this too |
Contributor Author
| This was all basically discussed before hand anyway: I'm calling 2 +1s good enough. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@codeclimate/review this copies over what was added & discussed on
browser.