Disallow extra spacing for token alignment #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
```ruby # bad something = 1 another = 2 # good something = 1 another = 2 ```
Contributor
| Hmmm the tricky thing is that we align tokens when it's part of a list of already aligned tokens: something = 1 + new = 3 another = 2I'd be happy to stop doing that though if others agree |
Contributor Author
| In that case, would it make sense to change the list to remove the alignment? We could also remove the token alignment as part of the rubocop config update for specific repos. |
Contributor
| Yeah I'd be cool with removing the token alignment. You might also be able to auto-correct them when you update the rubocop.yml, which would make my point moot. |
Contributor Author
Good point. I think this is a violation that rubocop can autocorrect 👍 |
Contributor
| Nice. |
Contributor
| 👍 |
dblandin added a commit that referenced this pull request Mar 11, 2016
Disallow extra spacing for token alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This rule should remove the need for "don't align tokens" comments in PRs. I've run into this coming from an organization that preferred token alignment.