Bump golang version to 1.18 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
roryphillips-sc commented May 18, 2022
| "fmt" | ||
| "github.com/codeclimate/cc-engine-go/engine" | ||
| "sourcegraph.com/sourcegraph/go-diff/diff" | ||
| "github.com/sourcegraph/go-diff/diff" |
Contributor Author
There was a problem hiding this comment.
I've changed the import from sourcegraph.com to github.com due to this error that is encountered when trying to run go mod tidy
sourcegraph.com/sourcegraph/go-diff/diff: sourcegraph.com/sourcegraph/go-diff@v0.6.1: parsing go.mod: module declares its path as: github.com/sourcegraph/go-diff but was required as: sourcegraph.com/sourcegraph/go-diff 
Contributor Author
| @filipesperandio Sorry to directly ping you, but you seem to be the last person who has merged code for this repo. |
Contributor
| Thanks for your contribution! Merged and closed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bumps golang version to 1.18 to allow support for generics syntax.
Current maintainability checks will fail due to invalid syntax.