Add Readup content for FC064 and FC065 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
{ "type":"issue", "check_name":"FoodCritic/FC064", "description":"Ensure issues_url is set in metadata", "categories":["Style"], "location": { "path":"cookbooks/foo/metadata.rb", "lines":{"begin":1,"end":1}}, "content":{ "body": "This warning is shown if a cookbook does not include the issues_url\nproperty in its metadata file. issues_url is used to point to the location\nfor submitting issues (bugs) for the cookbook and is currently parsed by\nSupermarket to add links to community cookbooks. Note: issues_url is a Chef\n12 only feature that will cause cookbook failures in Chef 11 so it should\nbe properly gated if the code will be run on Chef 11 hosts.\n" }, "remediation_points":50000,"fingerprint":"e4e87ba31f76f8d0256bc2a9f7e67315", "engine_name":"foodcritic" } |
ABaldwinHunter force-pushed the abh-content branch from 0bf2e8c to bd773a1 Compare Contributor Author
|
|
Contributor Author
| I’m curious about whether missing content in these issues could be causing them to be dropped by builder. Might be unrelated, but adding content here seems like a win either way! |
doc/rules.yml Outdated
| This warning is shown if a cookbook does not include the issues\_url | ||
| property in its metadata file. issues\_url is used to point to the location | ||
| for submitting issues (bugs) for the cookbook and is currently parsed by | ||
| Supermarket to add links to community cookbooks. Note: issues_url is a Chef |
| Content looks fine to me modulo my nits. I would not expect these to cause builder to drop anything. I would like to know what this engine does when the appropriate key isn't in this yml. |
ABaldwinHunter force-pushed the abh-content branch from bd773a1 to 319c4ca Compare Contributor Author
| @wfleming I think the summary defaults to an empty string https://github.com/codeclimate-community/codeclimate-foodcritic/blob/master/lib/cc/engine.rb#L80 I'd like to consider exposing the FC-nn codes as well in the description, but in a separate PR perhaps. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Culled from http://www.foodcritic.io/#FC064
@codeclimate/review @mrb