Initial implementation

[pbrisbin]

/cc @mrb @codeclimate/review

The current engine is deployed from here, which includes some
bug-fixes to the underlying tool.

This repo copied over its wrapper script with the following changes:

• General refactor

• Use the tool as-is

• Pass (essentially) include_paths/**/*.rb as cookbook paths

• Don't use the tool's exclude_paths feature

• Support config.tags

• Support config.cookbook_paths

  NOTE: If present, our own computed include_paths are ignored

• Hide issues on non-existent files

Comparing on an example repo:

Existing engine: https://codeclimate.com/github/mrb/mysql/issues

This version (required excluding test and spec):

== libraries/provider_mysql_service_base.rb (1 issue) == 78: Avoid repetition of resource declarations [foodcritic] == libraries/provider_mysql_service_smf.rb (1 issue) == 6: Prefer conditional attributes [foodcritic] == libraries/provider_mysql_service_systemd.rb (1 issue) == 6: Prefer conditional attributes [foodcritic] == libraries/provider_mysql_service_upstart.rb (1 issue) == 6: Prefer conditional attributes [foodcritic] 

(The same.)

[pbrisbin]

I should probably write some tests too.

[wfleming]

[wfleming]

Isn't there a -slim version of this we can use?

[pbrisbin]

I'll look and hope it compiles -- been running into some nokogiri issues.

[wfleming]

Oh, yeah, I think you need the ruby-dev package (& maybe some build tools as well), which -slim images don't come with. Bummer. If we don't need 2.3, maybe stick with our alpine image for now? The full Ruby image is pretty large, if I recall. (I should really make time to update our alpine image for newer Rubies).

[pbrisbin]

OK, this is ready for final review.

@mrb once merged, how would you like me to proceed on this? I propose:

• Get your approval (i.e. please test it)
• Open source this repo
• Add to submissions
• Ship it as the new version of this engine
• Update docs accordingly (see this repo's README)

[jpignata]

I tested this engine across a a handful of repos from https://github.com/chef-cookbooks and it looks 👍 to me.

[pbrisbin]

@jpignata I've rebased with (hopefully) a good commit message. If you agree, please feel free to merge, open source this repo, and begin the process of getting it in front of the customer.

I have to run, but hope to be back online ~10:15.