Skip to content

add new clang-tidy option #19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019
Merged

add new clang-tidy option #19698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Checks: >
performance-type-promotion-in-math-fn,
readability-container-size-empty,
readability-delete-null-pointer,
readability-redundant-control-flow,

WarningsAsErrors: '*'
HeaderFilterRegex: '/(?!external)/.*'
Expand Down
1 change: 0 additions & 1 deletion cocos/2d/CCActionInterval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2425,7 +2425,6 @@ DelayTime* DelayTime::clone() const

void DelayTime::update(float /*time*/)
{
return;
}

DelayTime* DelayTime::reverse() const
Expand Down
1 change: 0 additions & 1 deletion cocos/3d/CCOBB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ static void _getEigenVectors(Mat4* vout, Vec3* dout, Mat4 a)
v.transpose();
*vout = v;
*dout = d;
return;
}

static Mat4 _getOBBOrientation(const Vec3* vertPos, int num)
Expand Down
9 changes: 0 additions & 9 deletions cocos/network/SocketIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,6 @@ void SIOClientImpl::handshake()
HttpClient::getInstance()->send(request);

request->release();

return;
}

void SIOClientImpl::handshakeResponse(HttpClient* /*sender*/, HttpResponse *response)
Expand Down Expand Up @@ -562,9 +560,6 @@ void SIOClientImpl::handshakeResponse(HttpClient* /*sender*/, HttpResponse *resp
_timeout = timeout;

openSocket();

return;

}

void SIOClientImpl::openSocket()
Expand Down Expand Up @@ -593,8 +588,6 @@ void SIOClientImpl::openSocket()
{
CC_SAFE_DELETE(_ws);
}

return;
}

bool SIOClientImpl::init()
Expand Down Expand Up @@ -1004,8 +997,6 @@ void SIOClientImpl::onMessage(WebSocket* /*ws*/, const WebSocket::Data& data)
}
break;
}

return;
}

void SIOClientImpl::onClose(WebSocket* /*ws*/)
Expand Down
2 changes: 0 additions & 2 deletions tests/cpp-tests/Classes/PhysicsTest/PhysicsTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,8 +1593,6 @@ void PhysicsPositionRotationTest::onEnter()
body->setRotationOffset(45);
body->setTag(DRAG_BODYS_TAG);
addChild(offsetPosNode);

return;
}

std::string PhysicsPositionRotationTest::title() const
Expand Down