JSB SocketIO.connect supports to pass a CA cert file #17736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits April 21, 2017 09:44
…on` object. JSB just ignores it.
minggo approved these changes Apr 21, 2017
| I don't quite understand the official API documentation, it declares there is no parameter for socket.connect which is not as our current API. |
| Just add a optional parameter (caFilePath) for SocketIO.connect method，it will not conflict with the the API of socket io official. |
| Hi guys, please use english. We ask developers using english, we should obey it ourselves. |
| I'm ok now if the original C++ SocketIO::connect support such API form, it's just the difference between our implementation and SocketIO official documentation makes me confused, I think it should be fixed when we upgrade our C++ SocketIO implementation to the latest version |
pandamicro approved these changes Apr 21, 2017
minggo pushed a commit that referenced this pull request Apr 27, 2017
* remove APP_SHORT_COMMANDS setting (#17722) some developers report it will cause error on Windows though i can not reproduce it. It is strange, the setting is used to resolve command length limitation on Windows. * Particle font size should be a const value (#17676) * Particle font size should be a const value * Minor fix: CCStencilStateManager.hpp -> CCStencilStateManager.h in xcode project. * JSB SocketIO.connect supports to pass a CA cert file (#17736) * JSB SocketIO.connect supports to pass a CA cert file * The second parameter of SocketIO.connect function is probably a `option` object. JSB just ignores it.
stevetranby added a commit to stevetranby/cocos2d-x that referenced this pull request May 5, 2017
…futurePRs * commit '0bd075e46703704db50a5fef749f0bb47879c9e7': Fix Box2DTestBed keyboard error! (cocos2d#17741) JSB SocketIO.connect supports to pass a CA cert file (cocos2d#17736) Particle font size should be a const value (cocos2d#17676) remove APP_SHORT_COMMANDS setting (cocos2d#17722)
minggo pushed a commit that referenced this pull request Jun 5, 2017
* remove APP_SHORT_COMMANDS setting (#17722) some developers report it will cause error on Windows though i can not reproduce it. It is strange, the setting is used to resolve command length limitation on Windows. * Particle font size should be a const value (#17676) * Particle font size should be a const value * Minor fix: CCStencilStateManager.hpp -> CCStencilStateManager.h in xcode project. * JSB SocketIO.connect supports to pass a CA cert file (#17736) * JSB SocketIO.connect supports to pass a CA cert file * The second parameter of SocketIO.connect function is probably a `option` object. JSB just ignores it. * The optimization for huawei. (#17832) * The optimization for huawei. * setAnimationInterval fix for all platforms. * disable debug * include fix. * Uses better configuration for huawei optimization (#17838) * Uses better configuration for huawei optimization * Updates jar file and uncomment fps controlling code * [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (#17840) * update release not and version (#17845) * [android] Removes an unused variable sRegistered in Cocos2dxActvity.java. (#17861) * Updates jar to resolve warning while packaging APK file. (#17863) * update release date (#17870) * fix compiling error
stevetranby added a commit to stevetranby/cocos2d-x that referenced this pull request Jun 16, 2017
* commit '0bd075e46703704db50a5fef749f0bb47879c9e7': Fix Box2DTestBed keyboard error! (cocos2d#17741) JSB SocketIO.connect supports to pass a CA cert file (cocos2d#17736) Particle font size should be a const value (cocos2d#17676) remove APP_SHORT_COMMANDS setting (cocos2d#17722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.