Add sunrise and sunset in WeatherForecast Class #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cmfcmf added a commit that referenced this pull request Mar 21, 2015
…ise-and-sunset Add sunrise and sunset in WeatherForecast Class
| Thank you @emmanuelroecker! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If you wanted to get sunrise and sunset with getWeatherForecase, you had to call getWeather also, which causes double connection to openWeather.
Si on voulait le sunrise et le sunset avec getWeatherForecast, il était nécessaire d'appeler aussi getWeather, ce qui provoque une double connexion à openweather.