fix: Add time delay in DeleteStaleAll test for destinations #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
savme approved these changes Jun 18, 2025
kodiakhq bot pushed a commit that referenced this pull request Jun 18, 2025
🤖 I have created a release *beep* *boop* --- ## [4.84.2](v4.84.1...v4.84.2) (2025-06-18) ### Bug Fixes * Add time delay in DeleteStaleAll test for destinations ([#2191](#2191)) ([d98a293](d98a293)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.29.15 ([#2189](#2189)) ([9860e20](9860e20)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/licensemanager to v1.31.1 ([#2186](#2186)) ([7647d77](7647d77)) * **deps:** Update module google.golang.org/grpc to v1.72.2 ([#2187](#2187)) ([a999c81](a999c81)) * **deps:** Update module google.golang.org/grpc to v1.73.0 ([#2190](#2190)) ([2e3c192](2e3c192)) * Error handling in StreamingBatchWriter ([#1921](#1921)) ([6d71fb1](6d71fb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes a problem that we have in the
DeleteStaleAlltest for destinations which leads to flakey tests due to a lack of time difference between the insert and delete operations. We have already fixed this in theDeleteStaleBasictest here: https://github.com/cloudquery/plugin-sdk/blob/main/plugin/testing_write_delete.go#L58