fix: Optimized CSV writing #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
disq requested review from a team and erezrokah and removed request for a team 
erezrokah approved these changes Oct 3, 2024
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 7, 2024
Getting the S3 plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 7, 2024
Getting the GCS plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 7, 2024
Getting the azblob plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 7, 2024
Getting the file plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot pushed a commit that referenced this pull request Nov 7, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.0...v4.5.0) (2024-11-07) ### Features * Expose `max_row_group_length` option for Parquet writer ([#589](#589)) ([4a4b389](4a4b389)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.65.0 ([#581](#581)) ([136b836](136b836)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.0 ([#582](#582)) ([5ca0a10](5ca0a10)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.1 ([#583](#583)) ([69a6156](69a6156)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.67.0 ([#584](#584)) ([cab4c19](cab4c19)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.67.1 ([#585](#585)) ([d590743](d590743)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.0 ([#586](#586)) ([b19c239](b19c239)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.1 ([#587](#587)) ([3b9f708](3b9f708)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.2 ([#588](#588)) ([f2be0a6](f2be0a6)) * Optimized CSV writing ([#579](#579)) ([d688971](d688971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
All CSV records should have the same schema, so we don't need to extract it repeatedly for each record.