fix: Improve linting perf via caching #5900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bbernays requested review from erezrokah, hermanschaaf and yevgenypats as code owners 
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| I have opened a PR with this functionality in the |
erezrokah reviewed Dec 22, 2022
erezrokah reviewed Dec 22, 2022
.github/workflows/source_aws.yml Outdated
| cache-dependency-path: plugins/source/aws/go.sum | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| uses: bbernays/golangci-lint-action@58bce521b66ed125524e24eeec9522d765a8c2a7 |
There was a problem hiding this comment.
I would put the fork under cloudquery/ and also use the branch name directly cloudquery/golangci-lint-action@master so if we follow up with fixes we don't have to update this sha
erezrokah reviewed Dec 22, 2022
erezrokah approved these changes Dec 22, 2022
erezrokah approved these changes Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary