Fix assume_role handling when role_arn is given #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| /terratest |
nitrocode reviewed Jun 22, 2025
| %{~ if role_arn != "" ~} | ||
| | ||
| assume_role { | ||
| assume_role = { |
Member
There was a problem hiding this comment.
Couldn't an if statement be used here to add the equal sign if the terraform version is greater than 1.6 ?
Member
| The 1.6.0 minimum seems almost accurate. According to this reference, it looks like 1.6.1 is needed for the equal sign requirement. |
| 💥 This pull request now has conflicts. Could you fix it @mikalinnanoja-rovio? 🙏 |
There is a syntax error in the assume_role block with missing equals sign. As this part has anyway required newer terraform to work, document it in variable definition of role_arn input.
mikalinnanoja-rovio force-pushed the feature_assume_role_block_syntax branch from 4260e89 to 5bd566f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There is a syntax error in the assume_role block with missing equals sign.
As this part has anyway required newer terraform to work, document it in variable definition of role_arn input.
Related to
I did not commit
make init && make readmeoutputs because there are some amount of previous unrelated changes it generates.Tested on terraform 1.6.6 and 1.10.5 with latest 5.x provider.