Skip to content

feat: remove deprecated inheritance API #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

feat: remove deprecated inheritance API #260

merged 1 commit into from
Dec 7, 2022

Conversation

@maxime1992
Copy link
Contributor

@maxime1992 maxime1992 commented Jun 10, 2022 •
edited
Loading

⚠️ Review after #259 is merged ⚠️

✔️
@maxime1992 maxime1992 requested a review from zakhenry June 10, 2022 13:31
@maxime1992 maxime1992 self-assigned this Jun 10, 2022
@zakhenry zakhenry force-pushed the feat/remove-deprecated-api branch from ef5cf1c to db6f1c9 Compare June 13, 2022 04:11
@zakhenry
Copy link
Contributor

zakhenry commented Jun 13, 2022 •
edited
Loading

rebased locally and force pushed. @maxime1992 did something go weird with your git setup or workflow? Not sure why these MR's are only giving the option to Rebase and merge? It's messing with subsequent merge requests because they don't get the correct history and have to be rebased manually because of conflicts.

We should just do merge commits IMO, it is a true record of the history
zakhenry
zakhenry suggested changes Jun 13, 2022
View reviewed changes
zakhenry
zakhenry suggested changes Jun 13, 2022
View reviewed changes
@maxime1992
Copy link
Contributor Author

maxime1992 commented Jun 13, 2022

rebased locally and force pushed. @maxime1992 did something go weird with your git setup or workflow? Not sure why these MR's are only giving the option to Rebase and merge? It's messing with subsequent merge requests because they don't get the correct history and have to be rebased manually because of conflicts.

We should just do merge commits IMO, it is a true record of the history

We had this in the settings:

image

I've turned it off
@maxime1992 maxime1992 force-pushed the feat/remove-deprecated-api branch from db6f1c9 to 6918cad Compare June 13, 2022 08:49
@maxime1992 maxime1992 mentioned this pull request Jun 30, 2022
Open
@maxime1992 maxime1992 mentioned this pull request Nov 22, 2022
Open
@maxime1992
feat: remove deprecated API based on inheritance
4ab50c5 
BREAKING CHANGE: The old API is not available anymore
@maxime1992 maxime1992 force-pushed the feat/remove-deprecated-api branch from 6918cad to 4ab50c5 Compare December 7, 2022 08:32
maxime1992
maxime1992 commented Dec 7, 2022
View reviewed changes
Copy link
Contributor Author

@maxime1992 maxime1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reviewed, lgtm
@maxime1992 maxime1992 merged commit 0d6782a into master Dec 7, 2022
@maxime1992 maxime1992 deleted the feat/remove-deprecated-api branch December 7, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@maxime1992 @zakhenry