Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 14, 2022

This pr includes:

  1. base for AdvancedImage & AdvancedVideo components
  2. base for unit tests
  3. build script
  4. sample app under vue3/public
  5. coverage report generated when running npm run test
@ghost ghost requested a review from strausr July 14, 2022 11:45
{
"name": "@cloudinary/vue3",
"version": "0.1.0",
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you leave private on purpose?

@strausr strausr self-requested a review July 15, 2022 08:41
Copy link
Contributor

@strausr strausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that you don't keep the "private" in the package.json in the future

@ghost ghost merged commit 4482c6f into master Jul 15, 2022
@ghost ghost deleted the feat/vue-sdk branch July 15, 2022 09:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants