Skip to content

Fix incorrect responsive behaviour with SSR responsive #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2022
Merged

Fix incorrect responsive behaviour with SSR responsive #147

merged 2 commits into from
May 11, 2022

Conversation

@patrick-tolosa
Copy link
Contributor

@patrick-tolosa patrick-tolosa commented May 8, 2022

Pull request for cloudinary/frontend-frameworks

For which package is this PR?

HTML

What does this PR solve?

This PR fixes several problems with SSR.

  1. Remove incorrect plugin stops (returning null) in SSR, such as accessibility and responsive.
  2. In Responsive SSR, the default behaviour was changed to "Do nothing, NOOP" (Instead of returning the original unscaled image)
  3. In placeholder plugin, the plugin will not remove from the placeholder any resize attributes provided by the responsive plugin - this makes sense in both SSR and client side rendering as it avoids reloading a scaled down placeholder image.

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.
  • Relates to a github issue (link to issue).
@patrick-tolosa patrick-tolosa requested a review from strausr May 8, 2022 15:26
@strausr strausr merged commit b0d43eb into master May 11, 2022
@ghost ghost deleted the fix/adjust-ssr-responsive-plugin-rendering branch July 18, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@patrick-tolosa @strausr