Skip to content

Conversation

@tocker
Copy link
Contributor

@tocker tocker commented Dec 18, 2018

  • Upgrade dependencies to fix "ua-parser-js" security issue.
  • Implement dynamic test subject to allow tests to run on sources, (compiled) lib, and dist.
  • Fix webpack configuration.
@tocker tocker requested a review from eitanp461 December 18, 2018 15:50
@@ -0,0 +1 @@
pure-lockfile true No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create a lock file, but allow the developer to use one if present.

import { shallow, mount, render } from 'enzyme';
import Image from '../src/components/Image';
import Transformation from '../src/components/Transformation';
// import {default as foo} from './cloudinary-proxy';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Amir Tocker added 3 commits December 20, 2018 15:39
- Remove bower.json - Remove npm and yarn lock files - Add npmrc and yarnrc - Refactor tests setup - Add cloudinary-react proxy to test configuration - Add TEST_SUBJECT to travis configuration - Add React installation to travis configuration - Don't pack webpack.config.js in the npm package - Fix dist module name for React in webpack
@tocker tocker force-pushed the feature/upgrade-dependencies branch from 92f9d26 to 4597bd0 Compare December 20, 2018 13:42
@tocker tocker merged commit 4597bd0 into master Dec 20, 2018
@ghost ghost deleted the feature/upgrade-dependencies branch February 23, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants