- Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a lint rule to ban named imports from wrangler #11630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
baf13ae to 31bc581 Compare | await page?.close(); | ||
| await server?.close(); | ||
| // @ts-expect-error TODO: fix | ||
| await watcher?.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like watcher is never assigned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this as it is with the TODO for now so we can follow up in a different PR. Need to look into whether the watcher should be assigned or is just leftover from some other changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it say what needs fixing?
jamesopstad left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vic! The new shortcuts playground also needs a few corrections (that was added after you started this).
packages/vite-plugin-cloudflare/playground/block-concurrency-while/src/index.ts Outdated Show resolved Hide resolved
packages/vite-plugin-cloudflare/playground/module-resolution/vite.config.ts Outdated Show resolved Hide resolved
packages/vite-plugin-cloudflare/playground/spa-with-api/src/App.tsx Outdated Show resolved Hide resolved
packages/vite-plugin-cloudflare/playground/streaming/src/index.ts Outdated Show resolved Hide resolved
packages/vite-plugin-cloudflare/src/plugins/additional-modules.ts Outdated Show resolved Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
…hile/src/index.ts Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
…ite.config.ts Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
…p.tsx Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
04cada9 to 8193df1 Compare
Rationale:
Note that for the Wrangler version check to run in the Vite Plugin before we try to access a potentially missing export from Wrangler, one must now always import stuff from Wrangler using a namespace import. E.g.
rather than
Courtesy of Claude
A picture of a cute animal (not mandatory, but encouraged)